[test] Fix test:e2e local run#37719
Merged
Merged
Conversation
oliviertassinari
added
test
scope: code-infra
Netlify deploy previewhttps://deploy-preview-37719--material-ui.netlify.app/ Bundle size report |
sai6855
approved these changes
Jun 25, 2023
Member
sai6855
left a comment
sai6855
left a comment
There was a problem hiding this comment.
i guess i didn't have permissions to test in your branch, so i replicated all your changes locally and now i can run e2e tests.
Member
Author
This is odd, you should be able to run it locally |
Member
👍 I can run your branch and can run tests locally now. probably my previous approach was wrong. |
Member
Author
|
Ok, great, let's merge then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #29555, we try to use the port 3000 vercel/serve#680 as the default to run the test, but this port is already reserved: https://mui-org.notion.site/Ports-b113d0d4c76c4db9a0ef99c703d0084c?pvs=4.
I have copied the solution I did 2 years ago in mui/mui-x#1459 in MUI X.