[docs-infra] Cleanup code on demo code block expansion#38522
Merged
ZeeshanTamboli merged 3 commits intomui:masterfrom Aug 17, 2023
Merged
[docs-infra] Cleanup code on demo code block expansion#38522ZeeshanTamboli merged 3 commits intomui:masterfrom
ZeeshanTamboli merged 3 commits intomui:masterfrom
Conversation
ZeeshanTamboli
added
the
scope: docs-infra
Netlify deploy previewhttps://deploy-preview-38522--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
ZeeshanTamboli
requested review from
alexfauquette,
danilo-leal,
oliviertassinari and
zanivan
danilo-leal
reviewed
Aug 17, 2023
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Will let @alexfauquette approve it from an engineering standpoint but thank you for tackling this! Appreciate it! 🤙
alexfauquette
approved these changes
Aug 17, 2023
Member
alexfauquette
left a comment
alexfauquette
left a comment
There was a problem hiding this comment.
Thanks for the cleaning 👍
I will remember to open the console for the comming docs updates 🙈😊
Member
|
Sometimes, I wonder if we shouldn't have a test in the CI to smoke test these. For example, we have 
since #37319 (comment). Now, I can't think of any way that isn't overkill, so maybe it's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A warning is being thrown in docs while running it locally regarding
showSourceHintprop not being recognized by React on a DOM element. This might be due to the replacement of theToggleCodeTooltipcomponent with Material UI'sButtoncomponent in pull request #38421, which is now forwarding the prop.Noticed while running the docs locally.