[docs-infra] Add stray design adjustments#40623
Conversation
Netlify deploy previewBundle size report |
This comment was marked as resolved.
This comment was marked as resolved.
zanivan
left a comment
There was a problem hiding this comment.
Left some comments, but those are ultimately a matter of opinion, so feel free to merge it when you think it's ready 🚀
| '&:active': { transform: 'scale(.98)' }, | ||
| '&:focus-visible': { | ||
| outline: `3px solid ${alpha(theme.palette.primary[500], 0.5)}`, | ||
| outlineOffset: '2px', | ||
| }, |
There was a problem hiding this comment.
Oh, on ButtonBase, this is ambitious. There will likely be a lot more reset needed, #40747 sounds like only the tip of the iceberg.
There was a problem hiding this comment.
I've circled around both the marketing pages and the documentation, and aside from the instance in your PR, nothing crazy stood out. In any case, do let me know if you find any further regressions! 👍 Many buttons/links were missing proper focus state treatment prior to this.
There was a problem hiding this comment.
Many buttons/links were missing proper focus state treatment prior to this.
@danilo-leal True, this might make for the best tradeoff. We never thought about this use case for ButtonBase when introducing it, nice 😄.
find any further regressions
I mostly saw broken cases around tabs.
General run-through:
Examples: