[docs] Add theme.applyStyles() documentation with a codemod#40963
Closed
siriwatknp wants to merge 1 commit intomui:masterfrom
Closed
[docs] Add theme.applyStyles() documentation with a codemod#40963siriwatknp wants to merge 1 commit intomui:masterfrom
theme.applyStyles() documentation with a codemod#40963siriwatknp wants to merge 1 commit intomui:masterfrom
Conversation
siriwatknp
added
docs
mnajdova
reviewed
Feb 21, 2024
Comment on lines
+163
to
+176
| const MyComponent = styled('div')( | ||
| ({ theme }) => ({ | ||
| color: '#fff', | ||
| backgroundColor: theme.palette.primary.main, | ||
| '&:hover': { | ||
| boxShadow: theme.shadows[3], | ||
| backgroundColor: theme.palette.primary.dark, | ||
| }, | ||
| }), | ||
| ({ theme }) => | ||
| theme.applyStyles('dark', { | ||
| backgroundColor: theme.palette.secondary.main, | ||
| }), | ||
| ); |
Member
There was a problem hiding this comment.
Suggested change
| const MyComponent = styled('div')( | |
| ({ theme }) => ({ | |
| color: '#fff', | |
| backgroundColor: theme.palette.primary.main, | |
| '&:hover': { | |
| boxShadow: theme.shadows[3], | |
| backgroundColor: theme.palette.primary.dark, | |
| }, | |
| }), | |
| ({ theme }) => | |
| theme.applyStyles('dark', { | |
| backgroundColor: theme.palette.secondary.main, | |
| }), | |
| ); | |
| const MyComponent = styled('div')( | |
| ({ theme }) => ({ | |
| // default background color for light mode | |
| backgroundColor: theme.palette.primary.main, | |
| ...theme.applyStyles('dark', { | |
| // background color in dark mode | |
| backgroundColor: theme.palette.secondary.main, | |
| }), | |
| ); |
Maybe simplify and explain with comments?
mnajdova
reviewed
Feb 21, 2024
|
|
||
| ### Codemod | ||
|
|
||
| We provide a codemod to migrate your codebase from using `theme.palette.mode` to use `theme.applyStyles()`. |
Member
There was a problem hiding this comment.
Suggested change
| We provide a codemod to migrate your codebase from using `theme.palette.mode` to use `theme.applyStyles()`. | |
| You can use a codemod to migrate your codebase from using `theme.palette.mode` to use `theme.applyStyles()`. |
Member
Author
|
closed in favor of #42498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO