Skip to content

[material-ui] Refine the Sign-in and Sign-up templates#41192

Merged
zanivan merged 53 commits intomui:nextfrom
zanivan:template-polishing-sign
Mar 27, 2024
Merged

[material-ui] Refine the Sign-in and Sign-up templates#41192
zanivan merged 53 commits intomui:nextfrom
zanivan:template-polishing-sign

Conversation

@zanivan
Copy link
Collaborator

@zanivan zanivan commented Feb 19, 2024

@zanivan zanivan added docs Improvements or additions to the documentation. package: material-ui design This is about UI or UX design, please involve a designer. labels Feb 19, 2024
@zanivan zanivan self-assigned this Feb 19, 2024
@mui-bot
Copy link

mui-bot commented Feb 19, 2024

Netlify deploy preview

https://deploy-preview-41192--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 70ad02d

@zanivan zanivan marked this pull request as ready for review March 15, 2024 12:55
@zanivan zanivan requested review from danilo-leal and mbrookes March 15, 2024 12:55
@danilo-leal danilo-leal changed the base branch from master to next March 25, 2024 11:51
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 25, 2024
@zanivan zanivan requested a review from danilo-leal March 25, 2024 15:16
@zanivan zanivan requested a review from danilo-leal March 26, 2024 19:54
Copy link
Collaborator

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks for bearing with me on all the reviews 🤝 Last "major" request is to add labels to all the input fields so they're accessible. We can't rely on just the placeholder. This will naturally increase the height of all of the cards, so keep an eye out for mobile scrolling (everything should be fine, though).

@zanivan zanivan requested a review from danilo-leal March 26, 2024 22:32
Copy link
Collaborator

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it! I think the only design change I'd do right now is aligning the "Forgot password" with the "Password" label. Otherwise, specially on mobile, things get a bit all over the place.

Screenshot 2024-03-27 at 10 27 21

@zanivan zanivan merged commit 0ab846a into mui:next Mar 27, 2024
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 29, 2024
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design This is about UI or UX design, please involve a designer. docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants