[website] Split Toolpad documentation#41316
Merged
bharatkashyap merged 9 commits intomui:masterfrom Mar 15, 2024
Merged
Conversation
1 task
Netlify deploy previewhttps://deploy-preview-41316--material-ui.netlify.app/ Bundle size report |
bharatkashyap
added
the
website
bharatkashyap
changed the title
bharatkashyap
changed the title
danilo-leal
changed the title
danilo-leal
added
scope: toolpad
and removed
docs
danilo-leal
approved these changes
Mar 14, 2024
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Not sure if you're waiting for something, but it looks good to me!
| MUI Store: MUI Store | ||
| MUI Core: MUI Core | ||
| MUI Toolpad: MUI Toolpad | ||
| Toolpad: Toolpad |
Member
There was a problem hiding this comment.
Suggested change
| Toolpad: Toolpad | |
| MUI Toolpad: Toolpad | |
| MUI Toolpad: Toolpad |
handled in #41516.
Comment on lines
+54
to
+62
| if (firstFolder === 'toolpad') { | ||
| productCategoryId = 'toolpad'; | ||
| const secondFolder = asPathWithoutLang.replace(/^\/+[^/]+\/([^/]+)\/.*/, '$1'); | ||
| if (secondFolder === 'studio') { | ||
| productId = 'toolpad-studio'; | ||
| } else { | ||
| productId = 'toolpad-core'; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
@bharatkashyap Can we fix MuiProductId and MuiProductCategoryId? These types are wrong now. Thanks
This was referenced May 19, 2024
This was referenced Jun 5, 2024
Closed
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add productIds (
toolpad-studioandtoolpad-core) to separate splitting the Toolpad documentation into Toolpad Studio and Toolpad Core, as part of [docs] Split Toolpad into Studio and Core toolpad#3250Rename "MUI Toolpad" => "Toolpad"