[joy-ui][docs] Remove wrong CSS prop from the Sign-in-side template#41383
Merged
zanivan merged 8 commits intomui:masterfrom Mar 8, 2024
Merged
[joy-ui][docs] Remove wrong CSS prop from the Sign-in-side template#41383zanivan merged 8 commits intomui:masterfrom
zanivan merged 8 commits intomui:masterfrom
Conversation
The term align-items: left doesn’t exist and also There’s no need to worry about cross axis alignment because there’s no extra height. So, you can remove it from the code without any issues. Signed-off-by: Nedal <73669345+cipherlogs@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-41383--material-ui.netlify.app/ Bundle size report |
zannager
added
docs
cipherlogs
commented
Mar 6, 2024
Contributor
Author
cipherlogs
left a comment
cipherlogs
left a comment
There was a problem hiding this comment.
The current code uses clamp to switch between two values, which seems complicated for no reason. Since we already have access to the theme object, we could simplify this to make the code easier to read and reason about.
When using light mode, there’s an issue between the `769px` and `900px` width range. During this range, the divider is not visible. I recommend removing the collapsing breakpoint altogether and relying solely on the defaul `md` value breakpoint.
There's no need for an extra import, we can use the class name directly to target all asterisk slots withing the form container.
Better provide a meaningful feedback to users and screen readers, regardless of whether the component is mounted or not. Here are the changes made: 1. When component isn't mounted + an aria-label and a default icon will be provided for better context. + the button will be disabled + `onClick` will be attached, but it won't be invoked because the button is disabled 2. When component is mounted + The user will be able to toggle the color scheme as expected
zanivan
approved these changes
Mar 6, 2024
Collaborator
zanivan
left a comment
zanivan
left a comment
There was a problem hiding this comment.
Good catch! Thanks for tackling this! 🚀
auto-merge was automatically disabled
March 8, 2024 08:54
Head branch was pushed to by a user without write access
danilo-leal
changed the title
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
…ui#41383) Signed-off-by: Nedal <73669345+cipherlogs@users.noreply.github.com> Co-authored-by: cipherlogs <73669345+0x78logs@users.noreply.github.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term
align-items: leftdoesn’t exist and there’s no need to worry about cross axis alignment because there’s no extra height. So, you can remove it from the code without any issues.👉 https://deploy-preview-41383--material-ui.netlify.app/joy-ui/getting-started/templates/sign-in-side/