[docs-infra] Fix v4 docs <b> appearing in notifications#41390
Merged
alexfauquette merged 1 commit intomui:masterfrom Mar 7, 2024
Merged
[docs-infra] Fix v4 docs <b> appearing in notifications#41390alexfauquette merged 1 commit intomui:masterfrom
alexfauquette merged 1 commit intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-41390--material-ui.netlify.app/ Bundle size report |
Contributor
Author
|
Running typescript checks passed on my machine. Not sure why it's failing in ci.
|
Contributor
Author
|
Also, I can't access the labels on this PR, someone please add the |
flaviendelangle
approved these changes
Mar 7, 2024
Member
flaviendelangle
left a comment
flaviendelangle
left a comment
There was a problem hiding this comment.
Always nice to stop using this kind of API when we can 🤩
Member
This should be fixed now (see #41392). I rerun the CI Seems that we did not used links in those title since 2 years 👍 |
danilo-leal
changed the title
danilo-leal
added
scope: docs-infra
cipherlogs
pushed a commit
to cipherlogs/material-ui
that referenced
this pull request
Mar 8, 2024
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the
dangerouslySetInnerHTMLusage isn't necessary anymore now that the<b>tags wrap the entire title on all of the visible notifications. I'm assuming that removing the<b>from each title and instead wrapping the title in<b>tags in the JSX here will get rid of the<b>tags showing up in the v4 docs, as it looks like they are using the samenotifications.jsonfile to render the text for their notifications. If my assumption is incorrect, feel free to ignore my PR.v5 docs
v4 docs
