[pigment-css] Fix keyframes serialize styles error#41395
Merged
siriwatknp merged 23 commits intomui:masterfrom Mar 12, 2024
Merged
[pigment-css] Fix keyframes serialize styles error#41395siriwatknp merged 23 commits intomui:masterfrom
keyframes serialize styles error#41395siriwatknp merged 23 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-41395--material-ui.netlify.app/ Bundle size report |
siriwatknp
commented
Mar 8, 2024
Comment on lines
+37
to
+43
| const [, ...callParamsRest] = callParams; | ||
|
|
||
| callParamsRest.flat().forEach((item) => { | ||
| if ('kind' in item) { | ||
| this.dependencies.push(item); | ||
| } | ||
| }); |
Member
Author
There was a problem hiding this comment.
follow the styled implementation.
siriwatknp
commented
Mar 8, 2024
Comment on lines
+105
to
+107
| args.length > 0 | ||
| ? [styleObjOrTaggged as Interpolation<{}>, ...args] | ||
| : [styleObjOrTaggged as Interpolation<{}>], |
Member
Author
There was a problem hiding this comment.
This condition is required to prevent ILLEGAL_ESCAPE_SEQUENCE_ERROR from emotion because serializeStyles assumes that [] is an expression.
siriwatknp
commented
Mar 8, 2024
packages/pigment-react/tests/tag-call/fixtures/tag-call.input.js
Outdated
Show resolved
Hide resolved
siriwatknp
commented
Mar 8, 2024
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Passing empty
args([]) to emotion'sserializeStylesis not allowed.Full error:
The rest of the changes are splitting tests into small cases