[material-ui] Use interface instead of type for props#41500
Merged
siriwatknp merged 3 commits intomui:masterfrom Mar 18, 2024
Merged
[material-ui] Use interface instead of type for props#41500siriwatknp merged 3 commits intomui:masterfrom
siriwatknp merged 3 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-41500--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Mar 15, 2024
Member
Janpot
left a comment
There was a problem hiding this comment.
Thanks for looking into it. I suppose there is no straightforward way to add a test for this, right?
Member
Author
I guess there is but it would require some amount of effort. The idea is to use the build and run |
Member
Yep, that doesn't fall under what I meant with "straightforward" 😄 |
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced Jun 5, 2024
Closed
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40427
Material UI Popper
build before:
PopperPropsusage is replaced by its value with React.ElementType<...>build after:
PopperPropsis used, no usage of React.ElementType<...>.Base UI Popup
Before:
After: