[material-ui][docs] Fix landing page template's h1 size#41543
Merged
zanivan merged 4 commits intomui:masterfrom Mar 18, 2024
Merged
[material-ui][docs] Fix landing page template's h1 size#41543zanivan merged 4 commits intomui:masterfrom
zanivan merged 4 commits intomui:masterfrom
Conversation
zanivan
added
docs
Netlify deploy previewhttps://deploy-preview-41543--material-ui.netlify.app/ Bundle size report |
danilo-leal
approved these changes
Mar 18, 2024
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Looks good! Glad we fixed this — left a couple of small remarks. (Also, you can cut the component="h1" prop given the variant is the same as the tag we want this component to render as)
docs/data/material/getting-started/templates/landing-page/components/Hero.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/landing-page/components/Hero.js
Outdated
Show resolved
Hide resolved
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 5, 2024
Closed
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
clamp()to theh1element in the landing page template to fix the massive layout shift on mobile when switching themes.https://deploy-preview-41543--material-ui.netlify.app/material-ui/getting-started/templates/landing-page/