[docs][material-ui][Slider] Remove valueLabelFormat from restricted values demo so that the tooltip thumb label displays the same as the value text#41567
Merged
ZeeshanTamboli merged 1 commit intomui:nextfrom Mar 20, 2024
StylesTrip:slider-doc-update
Merged
[docs][material-ui][Slider] Remove valueLabelFormat from restricted values demo so that the tooltip thumb label displays the same as the value text#41567ZeeshanTamboli merged 1 commit intomui:nextfrom StylesTrip:slider-doc-update
valueLabelFormat from restricted values demo so that the tooltip thumb label displays the same as the value text#41567ZeeshanTamboli merged 1 commit intomui:nextfrom
StylesTrip:slider-doc-update
Conversation
…me as the value text
ZeeshanTamboli
added
docs
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
valueLabelFormat from restricted values demo so that the tooltip thumb label displays the same as the value text
ZeeshanTamboli
approved these changes
Mar 20, 2024
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Makes sense to me. valueLabelFormat isn't relevant in this demo.
ZeeshanTamboli
pushed a commit
to ZeeshanTamboli/material-ui
that referenced
this pull request
Mar 27, 2024
… values demo so that the tooltip thumb label displays the same as the value text (mui#41567)
pluvio72
pushed a commit
to pluvio72/material-ui
that referenced
this pull request
Mar 29, 2024
… values demo so that the tooltip thumb label displays the same as the value text (mui#41567)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-41567--material-ui.netlify.app/material-ui/react-slider/#restricted-values
Issue
Going through the Slider documentation, for all code examples that have value labels and tooltip thumb labels, these values match (see Custom marks and Label always visible examples) except for the Restricted values example.
Proposed Change
I'm proposing this change to have the tooltip thumb label match the value label by removing the
valueLabelFormatprop from the example. Doing this will then make the example look like the below screenshot: