[website] Refine button design and other details#41686
Merged
danilo-leal merged 13 commits intomui:nextfrom Mar 27, 2024
Merged
[website] Refine button design and other details#41686danilo-leal merged 13 commits intomui:nextfrom
danilo-leal merged 13 commits intomui:nextfrom
Conversation
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-41686--material-ui.netlify.app/ Bundle size report |
zanivan
reviewed
Mar 27, 2024
Collaborator
There was a problem hiding this comment.
Great improvement! Navigation feels way more consistent.
I'd make these gradients a bit subtler, making it to bottom right instead. I think this way the colored side is up, where the icon is. This brings me to the idea that the Icon is emanating the color :) (left the CSS just for reference)
backgroundImage: linear-gradient(to bottom right, rgba(235, 245, 255, 0.5) 10%, rgba(243, 246, 249, 0.2) 100%)
backgroundImage: linear-gradient(to bottom right, rgba(0, 58, 117, 0.1) 10%, rgba(20, 26, 31, 0.2) 100%) rgb(16, 20, 24)
zanivan
reviewed
Mar 27, 2024
zanivan
approved these changes
Mar 27, 2024
Collaborator
zanivan
left a comment
zanivan
left a comment
There was a problem hiding this comment.
Left a comment, but other than that, LGTM 🚀
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 29, 2024
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
DiegoAndai
pushed a commit
to DiegoAndai/material-ui
that referenced
this pull request
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mostly adds general adjustments to the branding theme's button box-shadow styles. Aside from that, I'm also including some stray improvements in other components (like, color, spacing, etc.).
https://deploy-preview-41686--material-ui.netlify.app/experiments/website/branding-theme-test/