[core] Automate cherry-pick of PRs from next -> master#41741
Merged
aarongarciah merged 1 commit intomui:nextfrom Apr 2, 2024
Merged
[core] Automate cherry-pick of PRs from next -> master#41741aarongarciah merged 1 commit intomui:nextfrom
next -> master#41741aarongarciah merged 1 commit intomui:nextfrom
Conversation
aarongarciah
added
the
needs cherry-pick
Netlify deploy previewhttps://deploy-preview-41741--material-ui.netlify.app/ Bundle size report |
aarongarciah
commented
Apr 2, 2024
| if: ${{ contains(github.event.pull_request.labels.*.name, 'needs cherry-pick') && github.event.pull_request.merged == true }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 |
Member
Author
There was a problem hiding this comment.
@mnajdova is there a reason to use the commit hash notation instead of using the version tag?
Suggested change
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | |
| uses: actions/checkout@v4.1.1 |
Member
There was a problem hiding this comment.
This has a great write up on the matter: https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash
mnajdova
approved these changes
Apr 2, 2024
Member
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Looks good, it's a nice contribution! I will update our guide to include adding this label if the PR needs to be cherry-picked.
aarongarciah
added a commit
to aarongarciah/material-ui
that referenced
this pull request
Apr 2, 2024
Collaborator
|
Awesome first PR! 🤝 |
Member
|
Nice 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @oliviertassinari suggested, this PR adds a GitHub Action to automate cherry-picking PRs from
nexttomaster(see Olivier's comment to see how it works). The code is an exact copy from MUI X (thanks @MBilalShafi !).cc @danilo-leal