[docs-infra] Add demo container design refinements#41948
Merged
danilo-leal merged 3 commits intomui:nextfrom Apr 18, 2024
Merged
[docs-infra] Add demo container design refinements#41948danilo-leal merged 3 commits intomui:nextfrom
danilo-leal merged 3 commits intomui:nextfrom
Conversation
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-41948--material-ui.netlify.app/ Bundle size report |
Collaborator
|
Just one small remark about the focus, though. It feels weird to be behind the button—and it only happens on the JS button 🤔 |
Collaborator
Author
|
Seems like a weird toggle button + button base-defined focus-styled related problem 🤔 Good catch, but I might treat it later so I can ship this one fast. 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Little tweaks to fine-tune the demo container even more. The primary change here is making the JS/TS toggle button look more like a pill rather than separate-looking buttons so there's no confusion with the code tabs that have been recently introduced.
https://deploy-preview-41948--material-ui.netlify.app/experiments/docs/demos/