[docs][material-ui] Add missing backticks to HTML tag in the installation page#41972
Merged
ZeeshanTamboli merged 6 commits intomui:nextfrom Apr 23, 2024
Miguelrom:patch-1
Merged
[docs][material-ui] Add missing backticks to HTML tag in the installation page#41972ZeeshanTamboli merged 6 commits intomui:nextfrom Miguelrom:patch-1
ZeeshanTamboli merged 6 commits intomui:nextfrom
Miguelrom:patch-1
Conversation
Netlify deploy previewBundle size report |
danilo-leal
changed the title
danilo-leal
added
docs
danilo-leal
approved these changes
Apr 20, 2024
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Looks great! Appreciate it!
Can I ask for you to point this PR to the next branch instead, though? You might need to rebase it so you maintain in the PR only the changed file.
Ehsansobhni
approved these changes
Apr 20, 2024
Backticks were added around the <head /> HTML tag to render it as code. Without it the tag just does not render. Signed-off-by: Miguel Romero <Miguelrom@users.noreply.github.com>
github-actions
bot
added
the
PR: out-of-date
Contributor
Author
|
I'm not sure if I did this correctly. I basically rebased locally, forced pushed the branch to my fork and then changed from master to next in the PR. If this doesn't work, no big deal. I'll try again some other day by making the change in the next branch. |
github-actions
bot
removed
the
PR: out-of-date
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
the
needs cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…tion page (#41972) Signed-off-by: Miguel Romero <Miguelrom@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Apr 24, 2024
…tion page (mui#41972) Signed-off-by: Miguel Romero <Miguelrom@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backticks were added around the HTML tag to render it as code.
Without it the tag just does not render.