Skip to content

[docs][material-ui][templates] Fix input props attributes in Landing Page template#42013

Merged
ZeeshanTamboli merged 3 commits intomui:nextfrom
tomhonour:next
Apr 27, 2024
Merged

[docs][material-ui][templates] Fix input props attributes in Landing Page template#42013
ZeeshanTamboli merged 3 commits intomui:nextfrom
tomhonour:next

Conversation

@tomhonour
Copy link
Contributor

@tomhonour tomhonour commented Apr 24, 2024

I encountered these 2 errors when using the landing page template:

'Warning: Invalid DOM property autocomplete. Did you mean autoComplete?'
'Warning: Invalid ARIA attribute ariaLabel. Did you mean aria-label?'

@mui-bot
Copy link

mui-bot commented Apr 24, 2024

Netlify deploy preview

https://deploy-preview-42013--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 53356d7

@tomhonour tomhonour changed the title Use keys autoComplete and aria-label for TextField inputProps [docs] Use keys autoComplete and aria-label for TextField inputProps Apr 24, 2024
@zannager zannager added docs Improvements or additions to the documentation. scope: text field Changes related to the text field. labels Apr 24, 2024
@zannager zannager requested a review from zanivan April 24, 2024 16:04
@ZeeshanTamboli ZeeshanTamboli added package: material-ui and removed scope: text field Changes related to the text field. labels Apr 27, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Use keys autoComplete and aria-label for TextField inputProps [docs][material-ui][templates] Fix input props attributes in Landing Page template Apr 27, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge. label Apr 27, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 842f1a6 into mui:next Apr 27, 2024
github-actions bot pushed a commit that referenced this pull request Apr 27, 2024
…Page template (#42013)

Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. needs cherry-pick The PR should be cherry-picked to master after merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants