[website] Fix code block design by changing the MarkdownElement import#42022
Merged
danilo-leal merged 2 commits intomui:nextfrom Apr 25, 2024
Merged
Conversation
danilo-leal
added
type: bug
Netlify deploy previewhttps://deploy-preview-42022--material-ui.netlify.app/ Bundle size report |
danilo-leal
changed the title
MarkdownElement importMarkdownElement import
Janpot
reviewed
Apr 25, 2024
Janpot
approved these changes
Apr 25, 2024
Collaborator
Author
Yup — planning to go the route I explored on #42011 to pull that off. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was introduced after #41859 where all
MarkdownElementimports were replaced by the version of this component that now lives in the @mui/docs package. The marketing site pages should use a different version of this component, yet with the same name, which doesn't have some CSS properties from "the original" that mess up with the showcase section's design.This PR is also a follow-up to a previous one (#42011), where I tried to fix this problem and improve the whole thing by removing the duplicate
MarkdownElementcomponents. In there, we concluded that it was best to have two PRs rather than one doing two things. This is part one. The second part will follow right after.