[material-ui] Filter only valid theme palette for generating styles#42147
Merged
siriwatknp merged 3 commits intomui:nextfrom May 17, 2024
Merged
[material-ui] Filter only valid theme palette for generating styles#42147siriwatknp merged 3 commits intomui:nextfrom
siriwatknp merged 3 commits intomui:nextfrom
Conversation
siriwatknp
added
the
type: enhancement
Netlify deploy previewhttps://deploy-preview-42147--material-ui.netlify.app/ packages/material-ui/material-ui.production.min.js: parsed: +0.01% , gzip: -0.10% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
reviewed
May 7, 2024
Member
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
Could we add a test to check for this?
Member
Author
Thanks for calling out! it's done. This will test all the component that iterate |
DiegoAndai
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #41367 (comment)