Add `InitColorSchemeScript` for Next.js App Router by siriwatknp · Pull Request #42247 · mui/material-ui

siriwatknp · 2024-05-15T13:14:05Z

I have followed (at least) the PR section of the contributing guide.

mui-bot · 2024-05-15T13:16:47Z

Netlify deploy preview

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Autocomplete: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
Autocomplete: parsed: +Infinity% , gzip: +Infinity%
TextField: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Select: parsed: +Infinity% , gzip: +Infinity%
SpeedDialAction: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Menu: parsed: +Infinity% , gzip: +Infinity%
Tooltip: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Tooltip: parsed: +Infinity% , gzip: +Infinity%
SwipeableDrawer: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Drawer: parsed: +Infinity% , gzip: +Infinity%
TabList: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/Snackbar: parsed: +Infinity% , gzip: +Infinity%
SpeedDial: parsed: +Infinity% , gzip: +Infinity%
Pagination: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/MenuButton: parsed: +Infinity% , gzip: +Infinity%
@mui/joy/ChipDelete: parsed: +Infinity% , gzip: +Infinity%
and 266 more changes

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 0e38328

This reverts commit 82d7240.

This reverts commit 38de969.

…nit-color-scheme-component

siriwatknp · 2024-06-10T16:31:24Z

packages/mui-system/src/cssVars/getInitColorSchemeScript.tsx

+      suppressHydrationWarning
+      nonce={typeof window === 'undefined' ? nonce : ''}


Reference: https://github.com/pacocoursey/next-themes/blob/bf0c5a45eaf6fb2b336a6b93840e4ec572bc08c8/next-themes/src/index.tsx#L198

DiegoAndai · 2024-06-10T17:18:14Z

packages/mui-material/src/styles/CssVarsProvider.tsx

-export { useColorScheme, getInitColorSchemeScript, CssVarsProvider, Experimental_CssVarsProvider };
+export {
+  useColorScheme,
+  getInitColorSchemeScript,


Should we deprecate getInitColorSchemeScript? Or do we expect users to still use it?

Good point. I think it can be removed but I'd do it in a separate PR and add note to the migration doc in the same PR.

DiegoAndai

LGTM, let's remember to deprecate/remove getInitColorSchemeScript

…nit-color-scheme-component

cherniavskii · 2024-07-03T09:58:02Z

docs/pages/_document.js

@siriwatknp This change blocks the monorepo upgrade for MUI X because we're using @mui/material@5:
https://app.netlify.com/sites/material-ui-x/deploys/66851d4bfe59880008524540#L240

Do you think we can keep using getInitColorSchemeScript here?

Nevermind, I found a PR that should address this and left a comment there 🙂
#42829 (comment)

cherniavskii · 2024-07-03T14:01:39Z

packages/mui-joy/src/styles/CssVarsProvider.tsx


+let warnedInitScriptOnce = false;
+
+const getInitColorSchemeScript: typeof deprecatedGetInitColorSchemeScript = (params) => {


@siriwatknp
How about adding @deprecated jsdoc here?
A warning in IDE is a good developer experience, IMO.
What do you think?

add InitColorSchemeScript

82d7240

siriwatknp changed the title ~~[POC] add InitColorSchemeScript for Next.js App Router~~ [POC] Add InitColorSchemeScript for Next.js App Router May 15, 2024

siriwatknp added the proof of concept label May 15, 2024

siriwatknp added 3 commits May 17, 2024 10:22

Revert "add InitColorSchemeScript"

38de969

This reverts commit 82d7240.

Revert "Revert "add InitColorSchemeScript""

c2ce63d

This reverts commit 38de969.

Merge branch 'next' of https://github.com/mui/material-ui into feat/i…

f876485

…nit-color-scheme-component

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 27, 2024

siriwatknp added 3 commits June 10, 2024 15:24

Merge branch 'next' of https://github.com/mui/material-ui into feat/i…

8006268

…nit-color-scheme-component

reexport InitColorSchemeScript as component

e18a6d0

add test

10683e6

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 10, 2024

siriwatknp changed the title ~~[POC] Add InitColorSchemeScript for Next.js App Router~~ Add InitColorSchemeScript for Next.js App Router Jun 10, 2024

siriwatknp added 4 commits June 10, 2024 15:56

update docs

394b59e

spec

1ef5f65

add nonce type

bef0a77

ignore CssVarsProvider from rsc

9582d24

siriwatknp marked this pull request as ready for review June 10, 2024 09:57

zannager requested a review from brijeshb42 June 10, 2024 11:38

siriwatknp requested review from DiegoAndai and mnajdova June 10, 2024 16:23

siriwatknp commented Jun 10, 2024

View reviewed changes

DiegoAndai reviewed Jun 10, 2024

View reviewed changes

DiegoAndai approved these changes Jun 12, 2024

View reviewed changes

Merge branch 'next' of https://github.com/mui/material-ui into feat/i…

285b3cc

…nit-color-scheme-component

siriwatknp added 13 commits June 13, 2024 18:33

split InitColorSchemeScript

8fa07a0

fix path

34eab69

fix ignore path

d480e9c

fix lint

00129fe

update docs

334d09e

add InitColorSchemeScript to joy

d3859a0

use InitColorSchemeScript in docs

92493b2

update docs

3256350

fix joy rsc ignore

2471c88

trigger build

52dddfd

Merge branch 'next' of https://github.com/mui/material-ui into feat/i…

1b3cd47

…nit-color-scheme-component

skip demo for InitColorSchemeScript

c11fb6b

pnpm install

0e38328

siriwatknp merged commit 58831f0 into mui:next Jun 14, 2024

LukasTy mentioned this pull request Jun 17, 2024

Bump @mui/monorepo digest to e5030ad mui/mui-x#13491

Merged

1 task

siriwatknp added a commit to siriwatknp/material-ui that referenced this pull request Jul 3, 2024

Add InitColorSchemeScript for Next.js App Router (mui#42247)

99959e3

siriwatknp mentioned this pull request Jul 3, 2024

[material-ui][joy-ui] Add InitColorSchemeScript for Next.js App Router #42829

Merged

1 task

cherniavskii reviewed Jul 3, 2024

View reviewed changes

DiegoAndai mentioned this pull request Jul 4, 2024

[material-ui][joy-ui] Remove warning from getInitColorSchemeScript #42838

Merged

1 task

joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024

Add InitColorSchemeScript for Next.js App Router (mui#42247)

7240fca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `InitColorSchemeScript` for Next.js App Router#42247

Add `InitColorSchemeScript` for Next.js App Router#42247
siriwatknp merged 25 commits intomui:nextfrom
siriwatknp:feat/init-color-scheme-component

siriwatknp commented May 15, 2024 •

edited

Loading

Uh oh!

mui-bot commented May 15, 2024 •

edited

Loading

Uh oh!

siriwatknp Jun 10, 2024

Uh oh!

DiegoAndai Jun 10, 2024

Uh oh!

siriwatknp Jun 11, 2024

Uh oh!

DiegoAndai left a comment

Uh oh!

cherniavskii Jul 3, 2024

Uh oh!

cherniavskii Jul 3, 2024

Uh oh!

cherniavskii Jul 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		suppressHydrationWarning
		nonce={typeof window === 'undefined' ? nonce : ''}


		let warnedInitScriptOnce = false;

		const getInitColorSchemeScript: typeof deprecatedGetInitColorSchemeScript = (params) => {

Uh oh!

Conversation

siriwatknp commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Netlify deploy preview

Bundle size report

Uh oh!

siriwatknp Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

DiegoAndai Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

siriwatknp Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

DiegoAndai left a comment

Choose a reason for hiding this comment

Uh oh!

cherniavskii Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

cherniavskii Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

cherniavskii Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

siriwatknp commented May 15, 2024 •

edited

Loading

mui-bot commented May 15, 2024 •

edited

Loading