[docs][material-ui][Tabs] Improve the Basic Tabs demo#42374
Merged
ZeeshanTamboli merged 3 commits intomui:nextfrom May 28, 2024
Merged
[docs][material-ui][Tabs] Improve the Basic Tabs demo#42374ZeeshanTamboli merged 3 commits intomui:nextfrom
ZeeshanTamboli merged 3 commits intomui:nextfrom
Conversation
1 task
oliviertassinari
added
docs
ZeeshanTamboli
changed the title
Netlify deploy previewhttps://deploy-preview-42374--material-ui.netlify.app/ Bundle size report |
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Okay, this looks fine to me. Argos detected the change: https://app.argos-ci.com/mui/material-ui/builds/28226/91645046, which is expected. I'd like others' opinions on this. For reviewers, please see the discussion in #42253. And also the discussion in issue #21015.
michaldudak
approved these changes
May 27, 2024
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
The code looks OK. The rendered text now has a different font, but it's actually OK, as it's more inline with Material Design (and less with our custom theme).
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
the
needs cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A continuation of #42253
To prevent the validateDOMNesting warning that occurs when users place certain elements inside Tabs, we can remove the Typography component from BasicTabs demo. Users don't realize Typography renders a
ptag, leading to warnings when they copy and paste the demo code into their applicationsThe
ptag can only contain inline elements. This means that placing a div tag inside it is inappropriate since the div tag is a block element. Improper nesting can cause issues such as rendering extra tags, which can affect the JavaScript and CSS. This is why we encounter the validateDOMNesting warning #21015