[code-infra] Skip charts animation for visual regression test#42530
[code-infra] Skip charts animation for visual regression test#42530alexfauquette merged 4 commits intomui:nextfrom
Conversation
Netlify deploy previewhttps://deploy-preview-42530--material-ui.netlify.app/ Bundle size report |
test/regressions/index.js
Outdated
|
|
||
| const blacklist = [ | ||
| 'docs-getting-started-templates-dashboard-internals-components/CustomIcons.png', // No public components | ||
| // Next components are tested by docs-getting-started-templates-dashboard-components/MainGrid.png |
There was a problem hiding this comment.
| // Next components are tested by docs-getting-started-templates-dashboard-components/MainGrid.png | |
| // The following components are tested by docs-getting-started-templates-dashboard-components/MainGrid.png |
The downside is that this list must be manually synchronized with the demos. But it's still better than running all demos unnecessarily, I guess.
|
Have you tried disabling animations in the playwright |
|
If the animation is handled by React Spring, I'm afraid configuring it in Playwright may not be enough. |
|
If the browser settings ask to avoid animation (mostly for a11y issues) the charts will skip them https://mui.com/x/react-charts/pie/#animation maybe that's what make it works |
|
Right, I'm also setting |
Should prevent that type of false positive
I also noticed we do screenshot of the dashboard and each component individually. Which seems like waisting resources. So I only kept the dashboard screenshot and remove all the subcomponents
See: #41757 (comment)