[codemod] Improve styled and sx prop transformation#42598
Merged
siriwatknp merged 5 commits intomui:nextfrom Jun 11, 2024
Merged
[codemod] Improve styled and sx prop transformation#42598siriwatknp merged 5 commits intomui:nextfrom
siriwatknp merged 5 commits intomui:nextfrom
Conversation
siriwatknp
added
package: codemod
Netlify deploy previewhttps://deploy-preview-42598--material-ui.netlify.app/ Bundle size report |
mnajdova
requested changes
Jun 10, 2024
Member
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Found just one problem, the rest looks good 👌
| ...theme.variants.plain.neutral, | ||
| variants: [{ | ||
| props: { | ||
| pressed: 'false' |
Member
There was a problem hiding this comment.
Shouldn't this be 'aria-pressed'?
mnajdova
approved these changes
Jun 11, 2024
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jun 12, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the test cases
theme.applyStylesand migrate docs #42498 (comment)theme.applyStylesand migrate docs #42498 (comment)theme.applyStylesand migrate docs #42498 (comment)