Skip to content

[docs][material-ui][Select] Fix the SelectAutoWidth demo menu item value#42648

Merged
ZeeshanTamboli merged 3 commits intomui:nextfrom
Danielkhakbaz:next
Jun 20, 2024
Merged

[docs][material-ui][Select] Fix the SelectAutoWidth demo menu item value#42648
ZeeshanTamboli merged 3 commits intomui:nextfrom
Danielkhakbaz:next

Conversation

@Danielkhakbaz
Copy link
Contributor

One of the value of the select component was set to 10 while the text that was getting shown was 20.

Signed-off-by: Daniel Khakbaz <danialkhakbaz.dk@gmail.com>
@mui-bot
Copy link

mui-bot commented Jun 15, 2024

Netlify deploy preview

https://deploy-preview-42648--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 654d10c

sai6855

This comment was marked as outdated.

Copy link
Member

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Danielkhakbaz run pnpm docs:typescript:formatted and commit changes to fix CI

@sai6855 sai6855 added docs Improvements or additions to the documentation. scope: select Changes related to the select. package: material-ui labels Jun 16, 2024
@danilo-leal danilo-leal changed the title Fix one of the value of the SelectAutoWidth component [material-ui][docs] Fix the SelectAutoWidth demo menu item value Jun 19, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs] Fix the SelectAutoWidth demo menu item value [docs][material-ui] Fix the SelectAutoWidth demo menu item value Jun 20, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Fix the SelectAutoWidth demo menu item value [docs][material-ui][Select] Fix the SelectAutoWidth demo menu item value Jun 20, 2024
@ZeeshanTamboli ZeeshanTamboli added type: bug It doesn't behave as expected. needs cherry-pick The PR should be cherry-picked to master after merge. labels Jun 20, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 9476434 into mui:next Jun 20, 2024
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
…value (#42648)

Signed-off-by: Daniel Khakbaz <danialkhakbaz.dk@gmail.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
…value (mui#42648)

Signed-off-by: Daniel Khakbaz <danialkhakbaz.dk@gmail.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. needs cherry-pick The PR should be cherry-picked to master after merge. scope: select Changes related to the select. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants