Skip to content

[joy-ui] Fix issues reported by the React Compiler#42671

Merged
mnajdova merged 4 commits intomui:nextfrom
anuujj:react-compiler-issue-mui-joy
Jun 20, 2024
Merged

[joy-ui] Fix issues reported by the React Compiler#42671
mnajdova merged 4 commits intomui:nextfrom
anuujj:react-compiler-issue-mui-joy

Conversation

@anuujj
Copy link
Copy Markdown
Contributor

@anuujj anuujj commented Jun 17, 2024

Part of #42564

@anuujj anuujj changed the title [mui-joy] Fixed issues reported by react compiler in mui-joy components [material-ui] [mui-joy] Fixed issues reported by react compiler in mui-joy components Jun 17, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Jun 17, 2024

Netlify deploy preview

https://deploy-preview-42671--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3d0a786

@anuujj anuujj marked this pull request as draft June 17, 2024 08:57
@anuujj anuujj marked this pull request as ready for review June 17, 2024 09:12
Copy link
Copy Markdown
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. In this case, we can silence all of the reported errors and leave the source code as is.

@anuujj
Copy link
Copy Markdown
Contributor Author

anuujj commented Jun 19, 2024

@aarongarciah thank you for the feedback. I have reverted the code changes and added appropriate comments.

Copy link
Copy Markdown
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danilo-leal danilo-leal changed the title [material-ui] [mui-joy] Fixed issues reported by react compiler in mui-joy components [joy-ui] Fix issues reported by the React Compiler Jun 19, 2024
@mnajdova mnajdova merged commit 6c87fe3 into mui:next Jun 20, 2024
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: joy-ui Specific to Joy UI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants