Skip to content

[docs-infra] Fix wrong migration#42675

Merged
siriwatknp merged 2 commits intomui:nextfrom
siriwatknp:fix/docs-demo-toolbar
Jun 19, 2024
Merged

[docs-infra] Fix wrong migration#42675
siriwatknp merged 2 commits intomui:nextfrom
siriwatknp:fix/docs-demo-toolbar

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 18, 2024

A regression from #42498

I think this case was my manual adjustment mistake. I missed the theme.breakpoints.up. The codemod improvement will come in a separate PR.

Before After
Screenshot 2024-06-18 at 08 43 48 Screenshot 2024-06-18 at 08 43 41

@siriwatknp siriwatknp added docs Improvements or additions to the documentation. type: regression A bug, but worse, it used to behave as expected. labels Jun 18, 2024
@siriwatknp siriwatknp requested a review from danilo-leal June 18, 2024 04:37
@mui-bot
Copy link

mui-bot commented Jun 18, 2024

Netlify deploy preview

https://deploy-preview-42675--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 209c6b5

@mnajdova
Copy link
Member

Can you do screenshots of what you are trying to fix? It would help with the review.

@danilo-leal danilo-leal changed the title [docs] Fix wrong migration [docs-infra] Fix wrong migration Jun 18, 2024
@danilo-leal danilo-leal added scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). and removed docs Improvements or additions to the documentation. labels Jun 18, 2024
Copy link
Collaborator

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jun! Added the screenshots in the description 👍

@siriwatknp siriwatknp merged commit c96d05e into mui:next Jun 19, 2024
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@oliviertassinari oliviertassinari added the type: bug It doesn't behave as expected. label Nov 24, 2024
@oliviertassinari oliviertassinari removed the type: bug It doesn't behave as expected. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants