[test-utils] Fix flushMicrotasks, export types#42771
Merged
michaldudak merged 2 commits intomui:nextfrom Jun 27, 2024
Merged
Conversation
Netlify deploy previewhttps://deploy-preview-42771--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Jun 27, 2024
Member
There was a problem hiding this comment.
Yes!
fyi: We have a few tickets in code infra around act and testing library:
actmust be awaited on https://github.com/orgs/mui/projects/21/views/2?pane=issue&itemId=66563904- add testing library eslint plugin https://github.com/orgs/mui/projects/21/views/2?pane=issue&itemId=66511046 which should catch some misusage of
act
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flushMicrotasksfunction as per https://floating-ui.com/docs/react#testing