Skip to content

[material-ui][Alert] Add ability to override slot props#42787

Merged
ZeeshanTamboli merged 4 commits intomui:nextfrom
alexey-kozlenkov:feat/alert-override-slot-props
Jun 30, 2024
Merged

[material-ui][Alert] Add ability to override slot props#42787
ZeeshanTamboli merged 4 commits intomui:nextfrom
alexey-kozlenkov:feat/alert-override-slot-props

Conversation

@alexey-kozlenkov
Copy link
Contributor

@alexey-kozlenkov alexey-kozlenkov commented Jun 29, 2024

Closes #42601

@mui-bot
Copy link

mui-bot commented Jun 29, 2024

Netlify deploy preview

https://deploy-preview-42787--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9453ade

@alexey-kozlenkov alexey-kozlenkov changed the title [material-ui][Alert] Add option to override slot props [material-ui][Alert] Add ability to override slot props Jun 29, 2024
@ZeeshanTamboli ZeeshanTamboli added typescript package: material-ui scope: alert Changes related to the alert. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Jun 30, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge. label Jun 30, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexey-kozlenkov Thanks for working on it. Looks good. I added a TypeScript module augmentation test.

@ZeeshanTamboli ZeeshanTamboli merged commit 5a2327f into mui:next Jun 30, 2024
github-actions bot pushed a commit that referenced this pull request Jun 30, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
@alexey-kozlenkov alexey-kozlenkov deleted the feat/alert-override-slot-props branch July 1, 2024 11:39
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs cherry-pick The PR should be cherry-picked to master after merge. scope: alert Changes related to the alert. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[material-ui][Alert] TS error when using slotProps with customised component

3 participants