[docs][material-ui][joy-ui][Autocomplete] Fix Hint demo#42990
Merged
ZeeshanTamboli merged 6 commits intomui:nextfrom Jul 23, 2024
Merged
[docs][material-ui][joy-ui][Autocomplete] Fix Hint demo#42990ZeeshanTamboli merged 6 commits intomui:nextfrom
Hint demo#42990ZeeshanTamboli merged 6 commits intomui:nextfrom
Conversation
Netlify deploy previewBundle size report |
Contributor
Author
|
Not able to add / update labels in this PR :( |
zannager
added
the
scope: autocomplete
ZeeshanTamboli
added
type: bug
ZeeshanTamboli
changed the title
Hint demo
ZeeshanTamboli
added
the
type: regression
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
This fix works well for selecting option from Autocomplete but I found other issues as well. See screen recording:
issue-42990.mp4
ZeeshanTamboli
changed the title
Hint demoHint demo
ZeeshanTamboli
added
the
needs cherry-pick
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
I fixed the overflowing hint text and also made sure that the hint text is cleared when a option as selected. Rest looks good. @ManthanGajjar Thanks for the pull request.
ZeeshanTamboli
approved these changes
Jul 23, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42882
Preview: https://deploy-preview-42990--material-ui.netlify.app/material-ui/react-autocomplete/#hint
Issue description
the dropdown does not show the selected option after clicking on it
Before:
Screen.Recording.2024-07-18.at.3.38.22.PM.mov
After:
Screen.Recording.2024-07-18.at.3.38.41.PM.mov