Conversation
Netlify deploy previewhttps://deploy-preview-43030--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Janpot
changed the title
Janpot
changed the title
Member
Author
|
🤔 Why didn't |
Janpot
added
the
scope: code-infra
michaldudak
approved these changes
Jul 23, 2024
Member
michaldudak
left a comment
michaldudak
left a comment
There was a problem hiding this comment.
pnpm lockfiles seem to be unstable at times. We had a similar category of a problem some time ago (reported in pnpm/pnpm#7823).
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing differences between running
pnpm dedupelocally and on CI. I manually removed the two entries in the lock file that were disappearing on the CI and rerandedupe. This seems to fix the mismatch. But this introduced some breakage in the types of@mui/material-ui-nextjsasstyleapparently can now beundefinedas well. This was fixed by inverting negative condition to a positive one.