Skip to content

[docs][material-ui][Card] Update CardMedia description#43067

Merged
ZeeshanTamboli merged 6 commits intomui:nextfrom
shahzaibdev1:patch-1
Jul 30, 2024
Merged

[docs][material-ui][Card] Update CardMedia description#43067
ZeeshanTamboli merged 6 commits intomui:nextfrom
shahzaibdev1:patch-1

Conversation

@shahzaibdev1
Copy link
Contributor

@shahzaibdev1 shahzaibdev1 commented Jul 25, 2024

Fixes #42859

This is my first contribution to open-source projects, please inform me if something's wrong by my side. I want to contribute to MUI as it's my fav project.

This is to update the issue mui#42859. [docs][material-ui][Card] CardMedia description is wrong 

This is my first contribution to open-source projects, please inform me if something's wrong by my side. I want to contribute to MUI as it's my fav project.

Signed-off-by: shahzaibdev1 <65166554+shahzaibdev1@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Jul 25, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 82c9db6

@shahzaibdev1 shahzaibdev1 marked this pull request as draft July 25, 2024 09:34
@shahzaibdev1 shahzaibdev1 marked this pull request as ready for review July 25, 2024 09:35
@zannager zannager added docs Improvements or additions to the documentation. scope: card Changes related to the card. labels Jul 25, 2024
@zannager zannager requested a review from aarongarciah July 25, 2024 13:05
@aarongarciah aarongarciah changed the title Update cards.md [material-ui][docs][Card] Update CardMedia description Jul 25, 2024
shahzaibdev1 and others added 2 commits July 26, 2024 15:04
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com>
Signed-off-by: shahzaibdev1 <65166554+shahzaibdev1@users.noreply.github.com>
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs][Card] Update CardMedia description [docs][material-ui][Card] Update CardMedia description Jul 29, 2024
@ZeeshanTamboli ZeeshanTamboli added the type: bug It doesn't behave as expected. label Jul 29, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge. label Jul 30, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ZeeshanTamboli ZeeshanTamboli merged commit f160039 into mui:next Jul 30, 2024
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: shahzaibdev1 <65166554+shahzaibdev1@users.noreply.github.com>
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com>
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. needs cherry-pick The PR should be cherry-picked to master after merge. scope: card Changes related to the card. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs][material-ui][Card] CardMedia description is wrong

6 participants