Skip to content

[docs][material-ui][Snackbar] Improve reason type in demos#43077

Merged
ZeeshanTamboli merged 4 commits intomui:nextfrom
sai6855:improve-sb
Jul 28, 2024
Merged

[docs][material-ui][Snackbar] Improve reason type in demos#43077
ZeeshanTamboli merged 4 commits intomui:nextfrom
sai6855:improve-sb

Conversation

@sai6855
Copy link
Member

@sai6855 sai6855 commented Jul 26, 2024

This PR applies SnackbarCloseReason type to reason argument.

@sai6855 sai6855 added docs Improvements or additions to the documentation. package: material-ui type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Jul 26, 2024
@mui-bot
Copy link

mui-bot commented Jul 26, 2024

Netlify deploy preview

https://deploy-preview-43077--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c7726d4

@sai6855 sai6855 requested a review from ZeeshanTamboli July 26, 2024 13:15
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Snackbar] Improve reason type in demos [docs][material-ui][Snackbar] Improve reason type in demos Jul 28, 2024
@ZeeshanTamboli ZeeshanTamboli added the scope: toast Changes related to the toast. label Jul 28, 2024
@ZeeshanTamboli ZeeshanTamboli added the needs cherry-pick The PR should be cherry-picked to master after merge. label Jul 28, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit 3e206fb into mui:next Jul 28, 2024
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
@oliviertassinari
Copy link
Member

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. needs cherry-pick The PR should be cherry-picked to master after merge. scope: toast Changes related to the toast. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants