[system] Reexport Pigment CSS from index file#43218
Merged
Conversation
Netlify deploy previewBundle size report |
Member
Author
|
This requires import {} from '@mui/material-pigment-css/theme';
import { Theme } from '@mui/material/styles';
declare module "@mui/material-pigment-css/theme" {
interface ThemeArgs {
theme: Theme
}
}I wonder if it makes more sense to augment the theme from |
Member
Author
|
@brijeshb42 Verified that the change is working as expected. |
brijeshb42
approved these changes
Aug 7, 2024
DiegoAndai
reviewed
Aug 7, 2024
Comment on lines
+79
to
+81
| const pigmentConfig = { | ||
| transformLibraries: ['@mui/material'], | ||
| }; |
mnajdova
approved these changes
Aug 7, 2024
Member
mnajdova
left a comment
There was a problem hiding this comment.
I reverted the changes on the migration-to-v6 which are not related to this PR. It looks good to me
DiegoAndai
approved these changes
Aug 7, 2024
Member
Author
Thanks @mnajdova |
|
|
||
| Open the browser and navigate to the localhost URL, you should see the app running with Pigment CSS. | ||
|
|
||
| ### Typescript |
Member
There was a problem hiding this comment.
Suggested change
| ### Typescript | |
| ### TypeScript |
Fixing this in #43751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The changes fixe theme augmentation issue with the latest beta:
Change
Remove the
@mui/material-pigment-css/themeand reexport from the index directly. Usingthemesubfolder adds unnecessary complexity and require user toimport type {} from @mui/material-pigment-css/themefirst.The change require users to set up TypeScript as below (documented in the migration guide):