[wip][poc] Add Pigment CSS screenshot test#43280
Conversation
Netlify deploy previewhttps://deploy-preview-43280--material-ui.netlify.app/ Bundle size report |
|
Changes look good to me. There are some small issues in the images (like first character of placeholder showing for Select) but we'll have to verify that locally first. |
It's the same locally, it's likely some bug/issue we need to look into. At least the screenshot test caught it ;) |
|
I dint see anything missing. LGTM |
|
@mnajdova may I ask you to add a fixture for the Select component? I don't see it in the added screenshots. |
Added the default demos and also one screenshot with an open select. |
Thanks! |
This PR sets up CI steps for testing screenshots test using Pigment CSS. It uses the pigment-css-vite-app that is already set up in the project for testing Material UI with Pigment CSS.
The fixtures are located in src/pages/fixtures directory. Any component added there will be automatically added as a screenshot (e.g. check the apps/pigment-css-vite-app/src/pages/fixtures/PigmentCSSDifferentChildren.js file).
The logic is very similar to how the other regressions tests are set up.
For demos screenshots, in the end I decided to use the components we have under the /material-ui routes. There were some issues with importing components from the docs, I kept getting the error
ERR_PNPM_RECURSIVE_RUN_FIRST_FAILwhen using https://vitejs.dev/guide/features.html#glob-importTODO: