[code-infra] Fix utils bundle size entrypoint#43304
Merged
Conversation
Janpot
added
the
scope: code-infra
Janpot
changed the title
Netlify deploy previewhttps://deploy-preview-43304--material-ui.netlify.app/ @material-ui/utils: parsed: -51.53% 😍, gzip: -30.92% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
LukasTy
approved these changes
Aug 15, 2024
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
The change makes sense. 👍
Do you know why code coverage could have decreased? 🤷
Member
Author
I saw identical coverage before and after on my local. I was assuming codocov being confused |
michaldudak
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an ESM entrypoint instead of a commonjs to get a more accurate depiction of reality. Also removing the alias as we can rely on pnpm package linking through the
publishConfig.directoryoption.We don't have this problem with other modules as they don't use the
esm/layout. We'll unify the package layout as part of improved ESM support.Noticed this in #43243
🤔 I was initially surprised by the large bundle size reduction. It looks like it now manages to aggressively tree-shake things such as the (in production) unused
chainProptypesand the functions it's called with.bundles diff