[code-infra] Fix typing issues with @mui-internal/api-docs-builder#43498
Merged
Janpot merged 1 commit intomui:masterfrom Aug 28, 2024
Merged
[code-infra] Fix typing issues with @mui-internal/api-docs-builder#43498Janpot merged 1 commit intomui:masterfrom
@mui-internal/api-docs-builder#43498Janpot merged 1 commit intomui:masterfrom
Conversation
Janpot
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-43498--material-ui.netlify.app/ Bundle size report |
Janpot
changed the title
@mui-internal/api-docs-builder
This was referenced Sep 25, 2024
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up on #43264, example: https://app.circleci.com/pipelines/github/mui/material-ui/137522/workflows/fa1c6a26-2bb8-4c47-a680-b33ce62c6a08/jobs/741391
@mui-internal/api-docs-builderhas the wrong path configured for@mui/internal-docs-utils. (Not sure why it's not extending from the global tsconfig like the other projects, but honestly, I think I prefer to do this on a per project basis)@mui/internal-docs-utilsand@mui/internal-test-utilsare using the-bflag. Not sure why, they don't have project references and we don't do this anywhere yet.