[ButtonBase] Export types used in ButtonBase props#43530
Merged
Janpot merged 1 commit intomui:masterfrom Jan 16, 2025
Merged
Conversation
13 tasks
Netlify deploy previewhttps://deploy-preview-43530--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
approved these changes
Jan 16, 2025
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
@Janpot Just saw this PR. Approving in case it’s relevant once the exports field is added to package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows X to avoid deeply nested imports in X https://github.com/mui/mui-x/blob/1a9426021bd72b5a1cc18e2c78a5a063d27be541/docs/data/data-grid/column-definition/RenderCellGrid.tsx#L4
In fact it would make sense to export all types that are referenced by public API. But that's another story 🙂
These imports will break once we put a hard limit on what is exported from the package