[test] Add font loader for pigment visual regression tests#43789
Merged
Janpot merged 2 commits intomui:masterfrom Sep 17, 2024
Merged
[test] Add font loader for pigment visual regression tests#43789Janpot merged 2 commits intomui:masterfrom
Janpot merged 2 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-43789--material-ui.netlify.app/ Bundle size report |
Member
|
Nice! 🚀 |
Member
|
Thanks for the fix! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't realize the regression tests have been completely duplicated for pigment. This copies the fontloader logic from the original regression tests to the pigment ones to make sure fontawesome is loaded before rendering the fixture.
Also removing this index page and centralize on the rendered fixtures instead.
Turns out this now also loads the correct font.