Closed
Conversation
Netlify deploy previewhttps://deploy-preview-43880--material-ui.netlify.app/ Bundle size report |
Member
Author
|
Superseded by #43880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache key calculation is executed before packages are installed, and this always results in an empty file.
The
--filterparameter is for filtering workspace packages this command operates on, not to filter listed packages. This command always returns an empty string. The cache key never changes. Thus we're always both downloading an old cache and re-installing playwright browsers.I'm moving the cache handling steps after the install step and I'm changing the command to filter on installed packages only. It's the positional argument in
pnpm list. I'm also removing--jsonas it's unnecessary and adding-rbecauseplaywrightis not installed at the top level. It's not the most ideal (*) output but probably closest to what we want that is doable with a simplepnpmcommand.I noticed restoring the cache takes as exactly long as running
playwright install.Current situation:

After the changes, we see the following numbers:
In Circleci
cache miss
cache hit
In both cases this increases the CI time. I propose to remove the cache altogether.
cc @mui/code-infra for your thoughtsSuperseded by #43881.Also removing a dead CircleCi link
(*) technically this output will invalidate a bit more often than strictly necessary, but we can probably live with it, no need to add extra complexity.