[material-ui] Support CSS variables with shadow DOM#43948
Merged
siriwatknp merged 5 commits intomui:masterfrom Oct 1, 2024
Merged
[material-ui] Support CSS variables with shadow DOM#43948siriwatknp merged 5 commits intomui:masterfrom
siriwatknp merged 5 commits intomui:masterfrom
Conversation
siriwatknp
added
the
type: enhancement
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
force-pushed
the
css-vars-shadow-dom
branch
from
001336c to
258a94d
Compare
Janpot
reviewed
Oct 1, 2024
Janpot
approved these changes
Oct 1, 2024
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
Looks good, added a suggestion for better intellisense
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
aarongarciah
approved these changes
Oct 1, 2024
oliviertassinari
added
the
scope: system
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #43886
preview: https://deploy-preview-43948--material-ui.netlify.app/material-ui/customization/shadow-dom/#3-css-theme-variables-optional
Changes
add new
rootSelectorfield to thecssVariablesconfig:createTheme({ cssVariables: { + rootSelector: ':host', }, })before: https://codesandbox.io/p/sandbox/shadow-dom-forked-s6w62q?workspaceId=2128292f-fbb6-4239-87e8-fa24491716c6
after: https://codesandbox.io/p/sandbox/material-ui-cra-ts-forked-kdw59g?file=%2Fsrc%2Findex.tsx%3A22%2C30