[material-ui][Badge] Make keys in anchor origin partial#43950
Merged
ZeeshanTamboli merged 10 commits intomui:masterfrom Oct 3, 2024
Merged
[material-ui][Badge] Make keys in anchor origin partial#43950ZeeshanTamboli merged 10 commits intomui:masterfrom
ZeeshanTamboli merged 10 commits intomui:masterfrom
Conversation
sai6855
added
scope: badge
Netlify deploy previewhttps://deploy-preview-43950--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
Oct 1, 2024
sai6855
requested review from
ZeeshanTamboli
and removed request for
ZeeshanTamboli
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #43859
Right now,
anchorOriginprop forBadgeexpects both keys (horizontal|vertical) to be present when passed, but i don't think there is need to make both keys as required as internally it is possible to handle logic even if one key is passed. This PR is to make keys inanchorOrginfrom required to partial