[material-ui][Autocomplete] Fix bug with child chip button events propagating to parent

[snapwich]

#42494 introduced a bug where the mouse down events in chips (such as clicking the delete button) was being handled in the autocomplete causing it to open/close as you deleted chips. i put the check back for if (event.target === event.currentTarget) { and added a test and it seems to fix the issue.

[snapwich]

i just added one more update. i found another bug introduced by #42494 where if you clicked the autocomplete root component (and not the input) it wouldn't open and close the menu which was a regression as it used to do that. i added another fix to add that behavior back. i'm assuming #42494's use case is still good as well as after applying this new fix (which undid some of their changes) their test they added still passes.

it all looks good to me now, but tbh i didn't totally understand what bug they were fixing.

[mui-bot]

Netlify deploy preview

https://deploy-preview-43982--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against dc6fdf8

[DiegoAndai]

Thanks for working on this @snapwich, I'm picking this one up, see #43976 (comment).

[DiegoAndai]

Tests added for:

• This PR's original bug:

  material-ui/packages/mui-material/src/Autocomplete/Autocomplete.test.js

  Line 834 in cc68375

  it('should not open the autocomplete popup when deleting chips', async () => {

• #44053:

  material-ui/packages/mui-material/src/Autocomplete/Autocomplete.test.js

  Line 856 in cc68375

  it('should toggle the autocomplete popup when clicking the popup indicator', async () => {

• #42432 replaced with a regression test as the unit test wasn't covering it properly:

  material-ui/test/regressions/index.test.js

  Line 136 in cc68375

  it('should not close immediately when textbox expands', async () => {

Waiting for #43976 (comment) to see if we can come up with a way to test #43976.

[DiegoAndai]

@aarongarciah may I ask you to review this? (I don't review it myself as I contributed heavily to it)

This PR reverts #42494, but keeps the onClick -> onMouseDown change so #42432 is not reintroduced.

I added tests for the issue reported in this PR, #44053, and #42432.

@cherniavskii if you consider it necessary, we could add a regression test for #43976 that simulates that issue's actions in the mui-x repo. I haven't opened a PR because the regression test setup in that repo is a bit different than Material UI's, and I'm not very familiar with it.

[aarongarciah]

Nice! Tested manually and all of the fixes seem to work as expected. The tests also look better now.

[ZeeshanTamboli]

@DiegoAndai @snapwich Thanks for fixing this and other related issues.