Skip to content

[docs] Try out further icons optimization (ignore)#44025

Closed
Janpot wants to merge 9 commits intomui:masterfrom
Janpot:opti-try
Closed

[docs] Try out further icons optimization (ignore)#44025
Janpot wants to merge 9 commits intomui:masterfrom
Janpot:opti-try

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Oct 6, 2024

@mui-bot
Copy link

mui-bot commented Oct 6, 2024

Netlify deploy preview

https://deploy-preview-44025--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c53111b

@Janpot Janpot closed this Oct 6, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 6, 2024

Observations:

  • https://deploy-preview-44025--material-ui.netlify.app/material-ui/material-icons/?query=a returns inconsistent results, the count changes between each load.
  • The page TTI seems to be around 1.2s instead of 1.9s. It seems we spend 80ms instead or 800ms initially on the search index to hydrate the page. It's a win if the person wants to click on an icon to expend it, but it seems equivalent if the first action the person does is a search. I would expect a search the most common action, so I'm not usure this makes a difference in the UX.

@oliviertassinari oliviertassinari added performance scope: icons Changes related to the icons. labels Oct 6, 2024
@Janpot
Copy link
Member Author

Janpot commented Oct 6, 2024

returns inconsistent results, the count changes between each load.

Yes, this should lazy initialize instead.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 6, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 6, 2024
@oliviertassinari
Copy link
Member

Work on this resumed at #44450. It seems that we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance scope: icons Changes related to the icons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants