[material-ui] Replace useThemeProps with useDefaultProps#44193
Merged
siriwatknp merged 2 commits intomui:masterfrom Oct 30, 2024
Merged
[material-ui] Replace useThemeProps with useDefaultProps#44193siriwatknp merged 2 commits intomui:masterfrom
useThemeProps with useDefaultProps#44193siriwatknp merged 2 commits intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-44193--material-ui.netlify.app/ TextField: parsed: -0.24% 😍, gzip: -0.22% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
reviewed
Oct 23, 2024
Member
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Should we add a conformance test for this? We already have one that tests using the ThemeProvider, we can add additional test for using only DefaultPropsProvider. What do you think?
Member
Author
Added. |
Merged
aarongarciah
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #44128
Several components still using
useThemePropsinstead ofuseDefaultProps. That's why usingDefaultPropsProviderdoes not work for these components.