[docs-infra] Enforce punctuation on descriptions#44292
Merged
oliviertassinari merged 2 commits intomui:masterfrom Nov 9, 2024
Merged
[docs-infra] Enforce punctuation on descriptions#44292oliviertassinari merged 2 commits intomui:masterfrom
oliviertassinari merged 2 commits intomui:masterfrom
Conversation
This was referenced Nov 1, 2024
Netlify deploy previewBundle size report |
3 tasks
Member
Author
|
Merging, this seems non-controversial. I have added point 22. in mui/base-ui#588 to keep some track of this, so all good 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this in: https://github.com/mui/toolpad/pull/4344/files#r1826369440.
I didn't look at how this can be replicated on the next docs-infra structure, but at least, in the meantime, we will make sure it's done right, less migration effort. I opened mui/toolpad#4351 and mui/mui-x#15229 to make it easier for those repositories to upgrade docs-infra with this PR in.