[docs-infra] Fix TOC RTL padding regression#44535
Merged
oliviertassinari merged 1 commit intomui:masterfrom Nov 30, 2024
Merged
[docs-infra] Fix TOC RTL padding regression#44535oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari merged 1 commit intomui:masterfrom
Conversation
oliviertassinari
added
type: bug
Netlify deploy previewhttps://deploy-preview-44535--material-ui.netlify.app/ Bundle size report |
Member
Author
|
Merging, under https://www.notion.so/mui-org/GitHub-PRs-7112d03a6c4346168090b29a970c0154?pvs=4#137cbfe7b66080049ba0fe580ec790b3. I will carry the burden if I introduce regressions with this, and I hope to have a positive review balance 😄. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #42498. This is broken in RTL since:
Before: https://deploy-preview-42498--material-ui.netlify.app/material-ui/react-button/
After: https://deploy-preview-44535--material-ui.netlify.app/material-ui/react-button/
Off-topic. Speaking of regressions, spending some time on this made me realize the dark mode and RTL toggle have an important performance regression: #44534.