Skip to content

[docs-infra] Fix display when ad-block triggers#44567

Merged
oliviertassinari merged 2 commits into
mui:masterfrom
oliviertassinari:docs-fix-ad-block
Nov 27, 2024
Merged

[docs-infra] Fix display when ad-block triggers#44567
oliviertassinari merged 2 commits into
mui:masterfrom
oliviertassinari:docs-fix-ad-block

Conversation

@oliviertassinari
Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari commented Nov 26, 2024

Since easylist/easylist#20644 is live, e.g. with uBlock Origin, the docs look broken:

SCR-20241126-tjum

https://mui.com/material-ui/react-alert/

Instead, we can add some margin, in case the block gets removed.

I also used the opportunity to make it harder to have selectors that reliably work for this block.

Preview:

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. type: regression A bug, but worse, it used to behave as expected. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). labels Nov 26, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Nov 26, 2024

Netlify deploy preview

https://deploy-preview-44567--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ab4fc65

Copy link
Copy Markdown
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. 👍

@oliviertassinari oliviertassinari enabled auto-merge (squash) November 27, 2024 10:08
@oliviertassinari oliviertassinari merged commit c45f084 into mui:master Nov 27, 2024
@oliviertassinari oliviertassinari deleted the docs-fix-ad-block branch January 28, 2025 23:12
@oliviertassinari oliviertassinari removed the type: bug It doesn't behave as expected. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants