Skip to content

[docs][material-ui] Fix crashing of DraggableDialog demo#44811

Merged
aarongarciah merged 1 commit intomui:v5.xfrom
sai6855:draggale-dialog
Dec 24, 2024
Merged

[docs][material-ui] Fix crashing of DraggableDialog demo#44811
aarongarciah merged 1 commit intomui:v5.xfrom
sai6855:draggale-dialog

Conversation

@sai6855
Copy link
Member

@sai6855 sai6855 commented Dec 19, 2024

@sai6855 sai6855 added docs Improvements or additions to the documentation. scope: dialog Changes related to the dialog. package: material-ui type: regression A bug, but worse, it used to behave as expected. labels Dec 19, 2024
@mui-bot
Copy link

mui-bot commented Dec 19, 2024

Netlify deploy preview

https://deploy-preview-44811--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8f39c8b

@sai6855
Copy link
Member Author

sai6855 commented Dec 19, 2024

@aarongarciah do you have any insight on why ci/circleci: test_e2e is failing?

@aarongarciah
Copy link
Member

aarongarciah commented Dec 19, 2024

@sai6855 it's probably related to the UMD build. @DiegoAndai pinned the UMD versions on the example being used in the test:umd script. See #44706.

The error is not the same though:

I'm clueless on why this started to fail now.

@zannager zannager requested a review from siriwatknp December 19, 2024 10:43
@DiegoAndai DiegoAndai requested review from DiegoAndai and removed request for siriwatknp December 19, 2024 12:35
@DiegoAndai
Copy link
Member

Looking into it

@DiegoAndai
Copy link
Member

DiegoAndai commented Dec 19, 2024

The reason is that after bumping React 19, we're trying to build the UMD files using React 19, which isn't supported. I'm working on a solution to rely on React 18 only for the UMD build process.

@DiegoAndai
Copy link
Member

Opened a PR to fix it: #44815

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 24, 2024
@DiegoAndai
Copy link
Member

@sai6855 the fix has been merged, please re-run the CI

@aarongarciah aarongarciah changed the title [material-ui][Dialog] Fix crashing of DraggableDialog demo [docs][material-ui] Fix crashing of DraggableDialog demo Dec 24, 2024
@aarongarciah aarongarciah merged commit 0f4e27d into mui:v5.x Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. PR: out-of-date The pull request has merge conflicts and can't be merged. scope: dialog Changes related to the dialog. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants