[material-ui][Slider] Fix arrow keys past the end for Slider with custom marks#45050
Merged
mj12albert merged 6 commits intomui:masterfrom Jan 22, 2025
Merged
[material-ui][Slider] Fix arrow keys past the end for Slider with custom marks#45050mj12albert merged 6 commits intomui:masterfrom
mj12albert merged 6 commits intomui:masterfrom
Conversation
joshkel
force-pushed
the
slider-custom-marks-nan
branch
from
9482667 to
48c4b12
Compare
Netlify deploy previewhttps://deploy-preview-45050--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
added
type: bug
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
@joshkel The fix looks correct, thanks! Just a few suggested changes in the tests. @mj12albert Could you review as well since this is a regression from #44537?
Co-authored-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com> Signed-off-by: Josh Kelley <joshkel@gmail.com>
…material-ui into slider-custom-marks-nan
mj12albert
approved these changes
Jan 21, 2025
Member
mj12albert
left a comment
mj12albert
left a comment
There was a problem hiding this comment.
Looks good ~ thanks for working on this @joshkel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45049