Skip to content

[TablePagination] Make onChangeRowsPerPage optional#9563

Merged
oliviertassinari merged 1 commit into
mui:v1-betafrom
evantrimboli:optional-onChangeRowsPerPage
Dec 20, 2017
Merged

[TablePagination] Make onChangeRowsPerPage optional#9563
oliviertassinari merged 1 commit into
mui:v1-betafrom
evantrimboli:optional-onChangeRowsPerPage

Conversation

@evantrimboli
Copy link
Copy Markdown
Contributor

@evantrimboli evantrimboli commented Dec 20, 2017

The select field is now hidden if configured with < 2 options, so it seems as though this should also be optional.

@oliviertassinari oliviertassinari added the scope: table Changes related to the table. label Dec 20, 2017
@oliviertassinari
Copy link
Copy Markdown
Member

Let's hold on #9561 for merging.

The select option is now hidden if configured with < 2 options, so it seems as though this should be optional.
@oliviertassinari oliviertassinari force-pushed the optional-onChangeRowsPerPage branch from 00b38ff to a4bf594 Compare December 20, 2017 19:41
@oliviertassinari oliviertassinari changed the title [TablePagination] Make onChangeRowsPerPage optional. [TablePagination] Make onChangeRowsPerPage optional Dec 20, 2017
@oliviertassinari oliviertassinari added the type: bug It doesn't behave as expected. label Dec 20, 2017
@oliviertassinari oliviertassinari merged commit e807a62 into mui:v1-beta Dec 20, 2017
@evantrimboli evantrimboli deleted the optional-onChangeRowsPerPage branch December 20, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: table Changes related to the table. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants